Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GetAvailableRooms method #44

Merged
merged 5 commits into from
Jul 7, 2018
Merged

Fix GetAvailableRooms method #44

merged 5 commits into from
Jul 7, 2018

Conversation

bhavik66
Copy link
Contributor

@bhavik66 bhavik66 commented Jul 7, 2018

The commented method GetAvailableRooms was not working because of Type Casting issue causing due to
Convert.ChangeType, for slove this I have created a custom class to convert the incoming data to object in the required format.

@endel endel merged commit 38e7b9f into colyseus:master Jul 7, 2018
@endel
Copy link
Member

endel commented Jul 7, 2018

That's pretty neat, thanks a lot for your pull-request @bhavik66! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants