subtle pitfall in handleMatchMakeRequest and colyseus.js

[amir-arad]

Steps to Reproduce (for bugs)

1. create a room using server-side matchMaker.create('space', {})
2. join this room from browser from page http://localhost:8080 using colyseus.js:

new Client('ws:' + window.location.href.substring(window.location.protocol.length)).join('space')

The browser then sends a POST request to http://localhost:8080//matchmake/join/space. notice the double slash - a trailing slash was added to the client .endpoint somewhere along the way. The server parses the path accordingly (see here and here )
3. However, when I use the same code in an inner page http://localhost:8080/game1 the request goes to http://localhost:8080/game1/matchmake/join/space and the server catches it but answers with {"code":4210,"error":"invalid method \"matchmake\""}.

I'm pretty sure this was just introduced in 0.13.0 .

IMO all matchmakers requests should go to https://${client.endpoint}/matchmake/... (single slash), and the server should be more strict with its path tests.

[amir-arad]

my local fix was using new Client('ws://' + window.location.host + '/')

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[github-actions]

This issue was closed because it has been stalled for 7 days with no activity.