Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to node v4 to avoid using --harmony #5

Closed
rahatarmanahmed opened this issue Jan 5, 2016 · 1 comment
Closed

Upgrade to node v4 to avoid using --harmony #5

rahatarmanahmed opened this issue Jan 5, 2016 · 1 comment

Comments

@rahatarmanahmed
Copy link
Contributor

We shouldn't have to use --harmony on our applications to use Colyseus.
#4 should take care of this from a support standpoint, but Colyseus's own npm scripts and documentation still use --harmony. I don't want to send a PR removing those yet as that's a pretty opinionated thing, but I think it'd be good to move forward.

Is there anything preventing colyseus from requiring node v4+?
@endel
Copy link
Member

endel commented Jan 5, 2016

It seems you already figured out! Thanks for your pull requests! :)

@endel endel closed this as completed Jan 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@endel @rahatarmanahmed