We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reported by Cucumba on Discord
Server latency simulation bug as previously mentioned here 🐛│bugs https://github.com/colyseus/colyseus/blob/0.15/packages/core/src/Server.ts#L239 https://github.com/colyseus/colyseus/blob/0.15/packages/transport/ws-transport/src/WebSocketTransport.ts#L73 https://github.com/colyseus/colyseus/blob/0.15/packages/transport/uwebsockets-transport/src/uWebSocketsTransport.ts#L124 Reason: previous function is being overridden each time when simulateLatency is called, it sets timeout for existing timeout, instead of original function
Here is example:
class Logger { log(message) { console.log(message) } } function simulateLatency(milliseconds) { const previousLog = Logger.prototype.log Logger.prototype.log = function(...args) { console.warn(milliseconds) setTimeout(() => previousLog.apply(this, args), milliseconds); } } const logger = new Logger() logger.log("msg") // no delay simulateLatency(1000) logger.log("msg") // delay 1 second simulateLatency(0) logger.log("msg") // delay 1 second simulateLatency(1000) simulateLatency(1000) simulateLatency(1000) logger.log("msg") // delay 4 seconds
The text was updated successfully, but these errors were encountered:
I fixed it in #663 + some test cases have been added
Sorry, something went wrong.
Thank you @afrokick 🎉
endel
No branches or pull requests
Reported by Cucumba on Discord
Server latency simulation bug as previously mentioned here 🐛│bugs
https://github.com/colyseus/colyseus/blob/0.15/packages/core/src/Server.ts#L239
https://github.com/colyseus/colyseus/blob/0.15/packages/transport/ws-transport/src/WebSocketTransport.ts#L73
https://github.com/colyseus/colyseus/blob/0.15/packages/transport/uwebsockets-transport/src/uWebSocketsTransport.ts#L124
Reason: previous function is being overridden each time when simulateLatency is called, it sets timeout for existing timeout, instead of original function
Here is example:
The text was updated successfully, but these errors were encountered: