Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: RelayRoom.ts public name:boolean #665

Closed
yty opened this issue Dec 24, 2023 · 1 comment · Fixed by #667
Closed

[Bug]: RelayRoom.ts public name:boolean #665

yty opened this issue Dec 24, 2023 · 1 comment · Fixed by #667

Comments

@yty
Copy link

yty commented Dec 24, 2023

Context

https://github.com/colyseus/colyseus/blob/master/packages/core/src/rooms/RelayRoom.ts

class Player extends Schema { // tslint:disable-line
  public connected: boolean;
  public name: boolean;
  public sessionId: string;
}

Bug description

public name: boolean; //=> public name: string;

Reproduction

No response

Steps to reproduce

This should be an oversight.

Environment & Versions

Colyseus 0.15.13

@afrokick
Copy link
Contributor

Thanks for the report!

Fixed in #667

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants