Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chinese Edition Fixing #85

Merged
merged 27 commits into from Sep 16, 2021
Merged

Chinese Edition Fixing #85

merged 27 commits into from Sep 16, 2021

Conversation

CocosGames
Copy link
Member

Fazri was right. The Chinese docs are really messed up.
This is the first fix, please let me check the result on the site.

@endel
Copy link
Member

endel commented Sep 2, 2021

Hi Coco, thanks for this.

Some notes about the Chinese docs:

  • Whenever you see code wrapped using a triple backslash (```) we should have line breaks to make sure the formatting looks like a block rather than "inline" in the generated HTML file. (You can compare the ssh root@remote.example.com command from Chinese and English versions)
  • We have special formatting for "notes", "tips" and "warnings" - in the current Chinese version they are slightly problematic. I think if you search for !!! you should find all of them
!!! note "Title of the note"
    Contents of the note

!!! tip "Title of the tip"
    Contents of the tip

!!! warning "Title of the warning"
    Contents of the warning

Please let me know if you have any questions. Cheers!

@CocosGames CocosGames changed the title first try. Chinese Edition Fixing Sep 5, 2021
@CocosGames
Copy link
Member Author

Now all md formats should be corrected. (polish needed)

@endel
Copy link
Member

endel commented Sep 13, 2021

Thank you @CocosGames - can we merge this PR, then? 👀

@CocosGames
Copy link
Member Author

Thank you @CocosGames - can we merge this PR, then? 👀

I think so. They should be displayed correctly. But they need more work on translation.

@endel endel merged commit 80a2236 into colyseus:master Sep 16, 2021
@endel endel mentioned this pull request Sep 16, 2021
@endel
Copy link
Member

endel commented Sep 16, 2021

Thanks a lot for all the work here @CocosGames 🚀 , if you feel more work/tidying-up is still necessary feel free to open a new PR please 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants