fix exception when removing listener during listeners check.

colyseus · Dec 7, 2017 · 37897b4 · 37897b4
1 parent e3e50c6
commit 37897b4
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "delta-listener",
-  "version": "2.1.1",
+  "version": "2.1.2",
   "description": "Deeply compare JavaScript objects and listen to changes.",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",

diff --git a/src/DeltaContainer.ts b/src/DeltaContainer.ts
@@ -98,7 +98,7 @@ export class DeltaContainer<T=any> {
 
             for (let j = 0, len = this.listeners.length; j < len; j++) {
                 let listener = this.listeners[j];
-                let pathVariables = this.getPathVariables(patches[i], listener);
+                let pathVariables = listener && this.getPathVariables(patches[i], listener);
                 if (pathVariables) {
                     listener.callback({
                         path: pathVariables,

diff --git a/test/delta_test.ts b/test/delta_test.ts
@@ -231,4 +231,15 @@ describe("DeltaContainer", () => {
         container.set(data);
     });
 
+    it("should allow removing listeners inside a listener", () => {
+        let container = new DeltaContainer({});
+        let listenerToRemove = container.listen("entities/:id", (change: DataChange) => {
+            container.removeListener(listenerToRemove);
+            numCalls++;
+        });
+        container.listen("players", (change: DataChange) => numCalls++);
+        container.set(clone(data));
+        assert.equal(numCalls, 2);
+    })
+
 })