Add Automatic-Module-Name for Java 9 compatibility #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lihaoyi Do you think we could get this (and com-lihaoyi/sourcecode#49) merged? This is a blocker for Java 9 compatibility for us right now. |
6 tasks
|
I tried to update this PR to reflect the recent changes to the build script. However, I was not able to find an option in mill to add something to the MANIFEST.MF file. It appears that https://github.com/lihaoyi/mill/blob/eececd6bbabd88b155a86e376a19d3aeee19cccf/main/src/modules/Jvm.scala#L193-L201 is responsible for writing the meta file, but the content does not seem to be configurable. @alexarchambault @olafurpg any ideas how to proceed to get a version that works with >= Java 9? |
33 tasks
|
@lihaoyi Is this PR still relevant for 2.2.3? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an
Automatic-Module-Nameto the JAR manifests, allowing the library to be used on the Java 9 module path.If the library was used before on the Java 9 module path, the module name was derived from the filename of the JAR at runtime to
sourcecode.2.12,sourcecode.utils.2.12, etc., which are not a valid Java identifiers.Fastparse is compatible with Java 9 when the dependency on sourcecode was updated to a version where com-lihaoyi/sourcecode#49 is included.
Closes #184