Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use maven-metadata.xml to find out dependency's pom #1099

Open
Iltotore opened this issue Jan 7, 2021 · 5 comments
Open

Use maven-metadata.xml to find out dependency's pom #1099

Iltotore opened this issue Jan 7, 2021 · 5 comments
Labels
upstream The issue originates in an upstream dependency

Comments

@Iltotore
Copy link
Contributor

Iltotore commented Jan 7, 2021

Actually, Mill seems to pull dependencies by directly building an URL to the supposed pom. However, this method doesn't work on some repositories like for Spigot dependencies.

Mill should first pull the first maven-metadata.xml (example) at <repoUrl>/<group separated by />/<artifactId>/maven-metadata.xml to retrieve the version's metadata file (example) and get the jar name from it.

@lefou
Copy link
Member

lefou commented Jan 7, 2021

Mill does not access the Maven repository directly, but uses the coursier API (https://get-coursier.io/) for it. So, this is an upstream issue and should be reported there.

@lefou
Copy link
Member

lefou commented Jan 7, 2021

FTR, I asked in the coursier discussions: coursier/coursier#1945

@Iltotore
Copy link
Contributor Author

Iltotore commented Jan 7, 2021

Ok, I was writing it but you were too fast.

@lefou lefou added the upstream The issue originates in an upstream dependency label Jan 7, 2021
@lefou
Copy link
Member

lefou commented Jan 11, 2021

@Iltotore Can you show what files mill (/coursier) tries to download and also show the exact failure? What files did you expect it to download instead?

@Iltotore
Copy link
Contributor Author

Iltotore commented Feb 17, 2021

Hello @lefou, I moved this issue to coursier/coursier. The files you're asking are at the same place at sent maven metadata in the first message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream The issue originates in an upstream dependency
Projects
None yet
Development

No branches or pull requests

2 participants