Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commands should be given a dest directory #61

Closed
lihaoyi opened this issue Dec 12, 2017 · 2 comments
Closed

Commands should be given a dest directory #61

lihaoyi opened this issue Dec 12, 2017 · 2 comments
Labels
easy The fix/solution for the issue is considered easy. A good starting point for newbies.

Comments

@lihaoyi
Copy link
Member

lihaoyi commented Dec 12, 2017

Currently T.ctx().dest only works for labelled Targets, which are publicly accessible. Tasks (which don't have a label) and overriden Targets are not given dest directories, because it's not clear what path that dest directory would have.

Currently, Commands do not have a dest directory. Given that the Commands do have a unique path by which they are run, they too should have a dest path assigned to them for them to use for scratch & output files. This would let us avoid creating temp dirs as we do here https://github.com/lihaoyi/mill/blob/bb61c05217671e80ba381b2cac869130c306baa8/scalaplugin/src/main/scala/mill/scalaplugin/ScalaModule.scala#L20

@lihaoyi lihaoyi added the easy The fix/solution for the issue is considered easy. A good starting point for newbies. label Dec 12, 2017
@lihaoyi
Copy link
Member Author

lihaoyi commented Dec 20, 2017

@prassee have you had time to take a look at this?

@lihaoyi
Copy link
Member Author

lihaoyi commented Dec 31, 2017

282d9a6

@lihaoyi lihaoyi closed this as completed Dec 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy The fix/solution for the issue is considered easy. A good starting point for newbies.
Projects
None yet
Development

No branches or pull requests

2 participants