Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overridden tasks that use super value are not cached #86

Closed
rtimush opened this issue Dec 29, 2017 · 1 comment
Closed

Overridden tasks that use super value are not cached #86

rtimush opened this issue Dec 29, 2017 · 1 comment

Comments

@rtimush
Copy link
Collaborator

rtimush commented Dec 29, 2017

If a task overrides one from a super trait and uses the base value, the caching is broken:

// base trait
def foo = T { Seq("base") } 
// subclass
override def foo = T{ super.foo() ++ Seq("override") }

Here is the test case: https://github.com/lihaoyi/mill/compare/task-override

@rtimush rtimush mentioned this issue Dec 29, 2017
5 tasks
@lihaoyi
Copy link
Member

lihaoyi commented Dec 29, 2017

This is probably a consequence of my recent Mirror/Discovered changes. I’ll take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants