Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to the Edit button in Compas Versions (rename SCL) #298

Closed
Stef3st opened this issue Nov 23, 2023 · 0 comments · Fixed by #300
Closed

Add functionality to the Edit button in Compas Versions (rename SCL) #298

Stef3st opened this issue Nov 23, 2023 · 0 comments · Fixed by #300
Labels
bug Something isn't working

Comments

@Stef3st
Copy link

Stef3st commented Nov 23, 2023

In CoMPAS Versions plugin is an edit symbol to rename the SCL file (see image below). This used to be handled by a wizard, but that doesn't seem necessary. And right now it lacks functionality

image

The code used for the wizard can still be found in this file: https://github.com/com-pas/compas-open-scd/blob/main/packages/compas-open-scd/src/compas-wizards/scl.ts

Acceptance Criteria:

  • When the edit button is clicked the rename project dialog comes up
  • Adding missing integration tests
@Sander3003 Sander3003 added the bug Something isn't working label Nov 27, 2023
@juancho0202 juancho0202 linked a pull request Dec 4, 2023 that will close this issue
CoMPAS Issues Overview Board automation moved this from To do to Done Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging a pull request may close this issue.

2 participants