fix: restored rename SCL button behavior #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test: added missing integration test Signed-off-by: Juan Munoz <juancho0202@gmail.com>
Signed-off-by: Juan Munoz <juancho0202@gmail.com>
Stef3st
changed the title
Stef3st
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
LGTM, I can't really test the behaviour because I need to have the CoMPAS data service for that. But since you didn't alter the code for the wizard, but just how you import it, I make the assumption that it works properly. When its in main we can test this for real and if changes are needed we make a new PR 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #298