-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to xgboost 1.0.0 - Use h2oai Predictor #708
Changes from all commits
3037ab1
f87816d
91951bc
d6540ac
a166b0e
01629c1
496349a
f444f21
55f550c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,8 +16,9 @@ object Dependencies { | |
lazy val slf4jVersion = "1.7.25" | ||
lazy val awsSdkVersion = "1.11.349" | ||
val tensorflowVersion = "1.11.0" | ||
val xgboostVersion = "0.90" | ||
val xgboostVersion = "1.0.0" | ||
val hadoopVersion = "2.6.5" // matches spark version | ||
val kryoVersion = "4.0.2" // Remove upon upgrading to xgboost 1.1.1 | ||
|
||
object Compile { | ||
val sparkMllibLocal = "org.apache.spark" %% "spark-mllib-local" % sparkVersion excludeAll(ExclusionRule(organization = "org.scalatest")) | ||
|
@@ -67,10 +68,12 @@ object Dependencies { | |
"ch.qos.logback" % "logback-classic" % logbackVersion, | ||
"com.typesafe.scala-logging" %% "scala-logging" % loggingVersion | ||
) | ||
val xgboostDep = "ml.dmlc" % "xgboost4j" % xgboostVersion // scala 2.11 only | ||
val xgboostPredictorDep = "biz.k11i" % "xgboost-predictor" % "0.3.1" | ||
|
||
val xgboostSparkDep = "ml.dmlc" % "xgboost4j-spark" % xgboostVersion // scala 2.11 only | ||
val kryo = "com.esotericsoftware" % "kryo" % kryoVersion | ||
val xgboostDep = "ml.dmlc" %% "xgboost4j" % xgboostVersion exclude("com.esotericsoftware.kryo", "kryo") | ||
val xgboostPredictorDep = "ai.h2o" % "xgboost-predictor" % "0.3.17" exclude("com.esotericsoftware.kryo", "kryo") | ||
|
||
val xgboostSparkDep = "ml.dmlc" %% "xgboost4j-spark" % xgboostVersion exclude("com.esotericsoftware.kryo", "kryo") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. did we run into issues with the kyro versions? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. They are brought in elsewhere and there is a version conflict. This is just making sure that others are chosen |
||
val hadoop = "org.apache.hadoop" % "hadoop-client" % hadoopVersion | ||
} | ||
|
||
|
@@ -119,9 +122,9 @@ object Dependencies { | |
|
||
val tensorflow = l ++= tensorflowDeps ++ Seq(Test.scalaTest) | ||
|
||
val xgboostRuntime = l ++= Seq(xgboostDep) ++ Seq(xgboostPredictorDep) ++ Test.spark ++ Test.sparkTest ++ Seq(Test.scalaTest) | ||
val xgboostRuntime = l ++= Seq(xgboostDep) ++ Seq(xgboostPredictorDep) ++ Seq(kryo) ++ Test.spark ++ Test.sparkTest ++ Seq(Test.scalaTest) | ||
|
||
val xgboostSpark = l ++= Seq(xgboostSparkDep) ++ Provided.spark ++ Test.spark ++ Test.sparkTest | ||
val xgboostSpark = l ++= Seq(xgboostSparkDep) ++ Seq(kryo) ++ Provided.spark ++ Test.spark ++ Test.sparkTest | ||
|
||
val serving = l ++= Seq(akkaHttp, akkaHttpSprayJson, config, Test.scalaTest, Test.akkaHttpTestkit) | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please remind me why these addons are needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh I wasn't able to build it without it. I can post the error message here by removing them and running tests again if you'd like. I also noticed that it was necessary in the spark-3.0.0 release branch here: https://github.com/combust/mleap/blob/spark-3.0.0/.travis.yml#L14
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍