Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Math unary operations #826

Merged
merged 4 commits into from
Sep 14, 2022

Conversation

shyamsunder00
Copy link
Contributor

Added 3 new Math unary operations
-Floor
-Ceil
-Round

@shyamsunder00
Copy link
Contributor Author

@jsleight Could you help review and merge if it is good ?

Copy link
Contributor

@jsleight jsleight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! lgtm.

(I'll merge once the test suite completes successfully post re-merging master)

@jsleight
Copy link
Contributor

jsleight commented Sep 1, 2022

ugh, we ran out of travis-ci credits again. @ancasarb can you re-petition travis-ci for credits again?

@shyamsunder00
Copy link
Contributor Author

Thanks @jsleight . @ancasarb Can we please look into it

@ancasarb
Copy link
Member

@jsleight i've re-requested credits again, i've copied you into the email as well.

@ancasarb
Copy link
Member

@shyamsunder00 sorry, we just got credits for Travis CI, can you please push a dummy commit, to re-trigger the builds? thanks!

@shyamsunder00
Copy link
Contributor Author

@ancasarb Thanks , its done
@jsleight

@ancasarb ancasarb merged commit 6d25bb8 into combust:master Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants