Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IOS-127: CSV enum strings #58

Merged
merged 3 commits into from Mar 1, 2023
Merged

IOS-127: CSV enum strings #58

merged 3 commits into from Mar 1, 2023

Conversation

jjohnstz
Copy link
Contributor

@jjohnstz jjohnstz commented Mar 1, 2023

No description provided.

@jjohnstz jjohnstz requested a review from miwright2 March 1, 2023 04:16
miwright2
miwright2 approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@miwright2 miwright2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I didn't test to confirm that the strings are the same, but I think it is right.

@miwright2
Copy link
Contributor

Log percent also looks good.

@jjohnstz jjohnstz merged commit 2a62bcd into develop Mar 1, 2023
@jjohnstz jjohnstz deleted the feature/ios-127-csv-enum-strings branch March 1, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miwright2 miwright2 miwright2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jjohnstz @miwright2