Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One character urls do not parse successfully. #1

Closed
dcoufal opened this issue Jan 3, 2018 · 3 comments
Closed

One character urls do not parse successfully. #1

dcoufal opened this issue Jan 3, 2018 · 3 comments
Assignees

Comments

@dcoufal
Copy link
Contributor

dcoufal commented Jan 3, 2018

Expected Behavior

If you parse the playlist

#EXT3MU
#EXTINF:5000
a

You should see the a line as a Location URL tag.

Observed Behavior

Parsing such a playlist gives no location. The line is completely skipped.

It's worth noting that this playlist:

#EXT3MU
#EXTINF:5000
aa

does produce the correct, expected Location URL tag with the value aa

Reproduction Steps

  1. Use the HLSParser to parse a playlist containing a Location URL that has one character.
  2. Examine the output HLSPlaylist. You will not see that Location URL in the output.

Observed on device(s):

  • All devices

Observed on OS Version(s):

  • All Versions
@dcoufal dcoufal self-assigned this Jan 3, 2018
@dcoufal
Copy link
Contributor Author

dcoufal commented Jan 3, 2018

This is tied to local Comcast issue 554.

@dcoufal
Copy link
Contributor Author

dcoufal commented Jan 3, 2018

Also worth noting this is very unlikely to occur in a real world playlist.

@dcoufal
Copy link
Contributor Author

dcoufal commented Jan 3, 2018

Fixed in #2

@dcoufal dcoufal closed this as completed Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant