Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contradictory definition of _citation_editor.id #346

Closed
vaitkus opened this issue Feb 2, 2023 · 1 comment · Fixed by #351
Closed

Contradictory definition of _citation_editor.id #346

vaitkus opened this issue Feb 2, 2023 · 1 comment · Fixed by #351
Labels
janitorial Small editing tasks

Comments

@vaitkus
Copy link
Collaborator

vaitkus commented Feb 2, 2023

The _citation_editor.id is defined as having a Single container with an Implied content type. However, the evaluation dREL of this item defines it as an Array of two elements:

    _citation_editor.id = [_citation_editor.citation_id,_citation_editor.ordinal]

Note, that the two items used to populate the array have different content types (Word, Integer). This seems like a bit of a deviation from current DDLm/dREL practices employed in CIF_CORE.

The _citation_editor.id data item seems to currently only be used as a convenient way of aggregating values since it is not explicitly specified as the primary key of the CITATION_EDITOR category (the key is currently a composite one and consists of the _citation_editor.citation_id, _citation_editor.ordinal pair).

One quick way to resolve the inconsistency could be to update the dREL code to concatenate the two values instead of putting them in an array, e.g.:

    _citation_editor.id = _citation_editor.citation_id + "_" + _citation_editor.ordinal

The underscore symbol was used as a connector to ensure that unique key values can always be generated (e.g. that concatenation of values 1,55 and 15,1 produce different strings).

Alternatively, the id item could be redefined to have a completely arbitrary value and potentially even become the primary category key.

What approach should be taken?

@jamesrhester jamesrhester added the janitorial Small editing tasks label Feb 3, 2023
@jamesrhester
Copy link
Contributor

This is dREL that was overlooked when we removed all such synthetic keys from the DDLm dictionary. The dREL should simply be removed, as we did for all other such cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
janitorial Small editing tasks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants