[CM-8208] Added debug mode to comet_llm #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaricom
requested changes
Sep 13, 2023
src/comet_llm/config.py
Outdated
| @@ -56,6 +59,10 @@ def api_key() -> Optional[str]: | |||
| return api_key # type: ignore | |||
|
|
|||
|
|
|||
| def logging_level() -> Optional[str]: | |||
| return _COMET_ML_CONFIG["comet_llm.logging_level"] | |||
There was a problem hiding this comment.
Looks like you need to add # type: ignore to avoid lint error
There was a problem hiding this comment.
It's not an Optional[str], its my bad
yaricom
approved these changes
Sep 14, 2023
alexkuzmik
requested changes
Sep 25, 2023
src/comet_llm/config.py
Outdated
| CONFIG_MAP_EXTENSION = {"comet.disable": {"type": int, "default": 0}} | ||
| CONFIG_MAP_EXTENSION = { | ||
| "comet.disable": {"type": int, "default": 0}, | ||
| "comet_llm.logging_level": {"type": str, "default": "INFO"}, |
There was a problem hiding this comment.
We decided to use the same name convention as we use in comet-ml, so no need to create comet_llm.logging_level, let's just reuse comet.logging.console.
alexkuzmik
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.