-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faster Retrieval of Images in Custom UI Panel #537
Comments
@tristanryerparke , thanks for the question! I suspect that your code is spending some extra time sorting the data (how many images have you logged? have you logged a lot of other items logged too?). Perhaps a faster method is to simply grab the last image logged (I believe that they are in logged order). See if that helps. If not, the bottle neck is probably in the experimentImages() call. |
I tried making this change:
Which may have sped things up a little bit, but it still takes much longer to load than the default image component (around 3s). |
Let me check with the engineering team next week to see if there is a way to speed up that. |
If on Comet cloud (comet.com), can you share the URL to an experiment that has the images logged? |
You can also email me that if you wish to keep private (doug@comet.com). |
Thanks doug, just emailed you the link. Edit: Checked an in-progress experiment and my custom panel seems snappy like the other finished experiments. Thanks, |
@tristanryerparke , thanks for the update. Well, we make refinements every week at all levels of the stack (SDK, backend, database, web endpoints, and frontend) so it could have been any number of things. I will pass on your praises to the engineering team! |
The latest version of comet.com has many updates. Please try it out and let us know if this works well for you. |
I'm just getting into creating custom panels (I'm usually a python programmer as opposed to JS) with comet UI and was looking for a way to display the most recent image generated by my experiment in a window that utilized the whole panel.
I came up with this code which works, but it is much slower than the built in image component with sliders/comparison.
It also fails to update sometimes.
Any suggestions on how I could make it as performant as the default image viewer?
The text was updated successfully, but these errors were encountered: