-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Go package #14
Conversation
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@@ -1,6 +1,6 @@ | |||
GOTOOLS = github.com/golangci/golangci-lint/cmd/golangci-lint | |||
PACKAGES=$(shell go list ./...) | |||
INCLUDE = -I=${GOPATH}/src/github.com/tendermint/tm-db -I=${GOPATH}/src -I=${GOPATH}/src/github.com/gogo/protobuf/protobuf | |||
INCLUDE = -I=${GOPATH}/src/github.com/CometBFT/CometBFT-db -I=${GOPATH}/src -I=${GOPATH}/src/github.com/gogo/protobuf/protobuf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lines 51-53 still contain Tendermint , is this ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking this up! I've fixed this in #16
@@ -5,8 +5,8 @@ import ( | |||
"context" | |||
"log" | |||
|
|||
grpcdb "github.com/tendermint/tm-db/remotedb/grpcdb" | |||
protodb "github.com/tendermint/tm-db/remotedb/proto" | |||
grpcdb "github.com/CometBFT/CometBFT-db/remotedb/grpcdb" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 39 and 49 refer to tmlibs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these kinds of references can be renamed in a follow-up when the docs are also updated.
db "github.com/tendermint/tm-db" | ||
protodb "github.com/tendermint/tm-db/remotedb/proto" | ||
db "github.com/CometBFT/CometBFT-db" | ||
protodb "github.com/CometBFT/CometBFT-db/remotedb/proto" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 62 refers to tendermint docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here re: when we update the documentation references.
Closes #11