feat: sqlite (using no build tags) #150
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/cometbft-db into faddat/bump-go-and-pebble
This reverts commit 307fc9b.
Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
…/cometbft-db into faddat/bump-go-and-pebble
|
We need the build tags because we don't want to bring dependencies of all the DBs we support. Why we support so many of them is another question, but it's a separate concern. As you know, there's a desire to trim everything and only support a single DB. |
|
Desires that we don't act on for three years are.... They kind of lose meaning sir |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the smiplified version of cometbft-db found here:
Without docker and build tags, cometbft-db is a lot easier to work on and sources of possible errors are eliminated.