Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate how to optimize vote propagation #13

Open
2 tasks
Tracked by #30
lasarojc opened this issue Dec 23, 2022 · 0 comments
Open
2 tasks
Tracked by #30

Investigate how to optimize vote propagation #13

lasarojc opened this issue Dec 23, 2022 · 0 comments
Assignees
@lasarojc
Labels
backlog A prioritized task in the team's backlog P:bandwidth-optimization Priority: Optimize bandwidth usage

Comments

@lasarojc
Copy link
Contributor

lasarojc commented Dec 23, 2022 •
edited

#backlog-priority
Was tendermint/tendermint#9924

In this task we investigate how to optimize the propagation of votes in Tendermint, using as input the results of #9922.

Votes are propagated for the current Height, for the current and previous rounds.
Once a vote has been received by a node, it informs its neighbors that such vote is no longer required.
Once a node is known to have a vote, it need not receive it again.

Tasks

  • Investigate a pull-push approach to votes propagation (on each round, first ask what is needed)
  • approaches by other projects

DoD:

  • We identified alternatives to how to propagate votes that may be applied to Tendermint and have an initial comparison of pros and cons of each alternative. This data serves as input to an ADR to address the problem.

References:
@lasarojc lasarojc mentioned this issue Dec 23, 2022
Open
3 tasks
@lasarojc lasarojc added the backlog A prioritized task in the team's backlog label Dec 23, 2022
sergio-mena pushed a commit that referenced this issue Feb 7, 2023
@thanethomson
ci: Deduplicate workflows on v0.34.x branch (#13)
b40b13e 
* ci: Deduplicate workflows on v0.34.x branch

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Restore generated code check config for now

Signed-off-by: Thane Thomson <connect@thanethomson.com>

---------

Signed-off-by: Thane Thomson <connect@thanethomson.com>
@lasarojc lasarojc self-assigned this Mar 27, 2023
@thanethomson thanethomson added the P:bandwidth-optimization Priority: Optimize bandwidth usage label Jun 20, 2023
cometcrafter pushed a commit to graphprotocol/cometbft that referenced this issue Apr 10, 2024
@czarcas7ic
Merge pull request cometbft#13 from osmosis-labs/adam/no-double-save-…
1e9012f 
…finalizeBlockResponse

perf(state/store): avoid double-saving ABCI responses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lasarojc lasarojc

Labels
backlog A prioritized task in the team's backlog P:bandwidth-optimization Priority: Optimize bandwidth usage
Projects
No open projects
CometBFT 2023
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thanethomson @lasarojc