Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CI to generate matching proto buff during rename #180

Closed
3 tasks done
lasarojc opened this issue Jan 23, 2023 · 0 comments
Closed
3 tasks done

Update CI to generate matching proto buff during rename #180

lasarojc opened this issue Jan 23, 2023 · 0 comments
Assignees
@lasarojc
Milestone
2023-Q1

Comments

@lasarojc
Copy link
Contributor

lasarojc commented Jan 23, 2023 •
edited
Loading

This issue is just to track the fix done on PR #173 and back ports and contributes to some tasks in #93
The fixes consisted in updating the CI to use go 1.19 when generating protobuf files, to match what most will have locally.
The fixes were captures in the following PRs:

There may be some overlapping with #172 and #170
@lasarojc lasarojc added the wip Work in progress label Jan 23, 2023
@lasarojc lasarojc self-assigned this Jan 23, 2023
@lasarojc lasarojc removed the wip Work in progress label Jan 23, 2023
@thanethomson thanethomson added this to the 2023-Q1 milestone Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lasarojc lasarojc

Labels
None yet
Projects
No open projects
CometBFT 2023
Status: Done
Milestone
2023-Q1
Development

No branches or pull requests
2 participants
@thanethomson @lasarojc