Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix generated code check in 0.37.x #179

Merged
merged 2 commits into from
Jan 23, 2023

Conversation

lasarojc
Copy link
Contributor

@lasarojc lasarojc commented Jan 23, 2023

Backport of the work done in #173, for main.

Proto-gen check fails after updating the CI but before running make proto-gen.
After running make proto-gen and submitting the updated files, the check passes.


PR checklist

  • Tests written/updated, or no tests needed
  • CHANGELOG_PENDING.md updated, or no changelog entry needed
  • Updated relevant documentation (docs/) and code comments, or no
    documentation updates needed

@lasarojc lasarojc changed the base branch from main to v0.37.x January 23, 2023 13:54
@lasarojc lasarojc force-pushed the lasarojc/fix_gen_code_check_0.37.x branch from 3152d3a to ffc9521 Compare January 23, 2023 14:02
@lasarojc lasarojc marked this pull request as ready for review January 23, 2023 14:13
@lasarojc lasarojc requested a review from a team as a code owner January 23, 2023 14:13
@lasarojc lasarojc changed the title fix generated code check in 0.37.x ci: fix generated code check in 0.37.x Jan 23, 2023
@lasarojc lasarojc merged commit 6c9ed37 into v0.37.x Jan 23, 2023
@lasarojc lasarojc deleted the lasarojc/fix_gen_code_check_0.37.x branch January 23, 2023 14:52
@lasarojc lasarojc mentioned this pull request Jan 23, 2023
3 tasks
gibson042 added a commit to agoric-labs/cometbft that referenced this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants