Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move vote_extension_enable_height to FeatureParams #2325

Closed
lasarojc opened this issue Feb 13, 2024 · 0 comments · Fixed by #2335
Closed

Move vote_extension_enable_height to FeatureParams #2325

lasarojc opened this issue Feb 13, 2024 · 0 comments · Fixed by #2335
Assignees
@lasarojc
Labels
abci Application blockchain interface backport-to-v1.x Tell Mergify to backport the PR to v1.x breaking A breaking change
Milestone
2024-Q1

Comments

@lasarojc
Copy link
Contributor

lasarojc commented Feb 13, 2024 •
edited by sergio-mena
Loading

#2231 introduced FeatureParams to aggregate opt-int feature enablement parameters. ABCIParam fields should be moved there.

A series of TODO were added by #2231, but the change should not be limited to those TODOs. In particular, updating the testing framework will require a lot of changes.

Addressed by #2335
@lasarojc lasarojc added abci Application blockchain interface breaking A breaking change backport-to-v1.x Tell Mergify to backport the PR to v1.x labels Feb 13, 2024
@lasarojc lasarojc mentioned this issue Feb 14, 2024
Merged
4 tasks
@lasarojc lasarojc linked a pull request Feb 14, 2024 that will close this issue
feat(pbts): Moving VoteExtensionsEnableHeight from ABCIParams to FeatureParams. #2335
Merged
4 tasks
@sergio-mena sergio-mena mentioned this issue Feb 19, 2024
Closed
14 tasks
@lasarojc lasarojc self-assigned this Feb 19, 2024
lasarojc added a commit that referenced this issue Feb 20, 2024
@lasarojc
feat(pbts): Moving VoteExtensionsEnableHeight from ABCIParams to Feat…
6490232 
…ureParams. (#2335)

Closes #2325 

---

#### PR checklist

- [ ] Tests written/updated
- [ ] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code
comments
- [ ] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec
@adizere adizere added this to the 2024-Q1 milestone Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lasarojc lasarojc

Labels
abci Application blockchain interface backport-to-v1.x Tell Mergify to backport the PR to v1.x breaking A breaking change
Projects
CometBFT
Status: Done
Milestone
2024-Q1
Development

Successfully merging a pull request may close this issue.

feat(pbts): Moving VoteExtensionsEnableHeight from ABCIParams to FeatureParams. cometbft/cometbft
2 participants
@adizere @lasarojc