Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: provide simple way to add new curves #2424

Open
2 tasks done
Tracked by #42
tac0turtle opened this issue Feb 23, 2024 · 4 comments
Open
2 tasks done
Tracked by #42

crypto: provide simple way to add new curves #2424

tac0turtle opened this issue Feb 23, 2024 · 4 comments
Labels
crypto Cryptography-related enhancement New feature or request needs-triage This issue/PR has not yet been triaged by the team.
Milestone

Comments

@tac0turtle
Copy link
Contributor

tac0turtle commented Feb 23, 2024

Feature Request

Summary

currently there is not a way to add new curves to comet unless you fork the software. This causes many forks for simple changes.

Problem Definition

adding new curves forces users to fork the software. (unless im missing something)

Proposal

add simple way to add new curves to be used for consensus key signing

Zondax is proposing an api to help with this in the sdk. we could look at hosting the new api in its own module to enable usage in comet as well

Tasks

@tac0turtle tac0turtle added enhancement New feature or request needs-triage This issue/PR has not yet been triaged by the team. labels Feb 23, 2024
@tac0turtle
Copy link
Contributor Author

tac0turtle commented Feb 24, 2024

to add on it would be nice to have the file system privval also take arbitrary curves. This way users dont also have to fork privval file once pluggable curves land

relevant tendermint/tendermint#5603 but allowing the node instanciator to set the underlying curve would be one step better than the issue linked

@cason
Copy link
Contributor

cason commented Feb 26, 2024

I think we would need a method such as RegisterKey at some place.

Now one can implement the crypto.PrivKey and crypto.PrivKey interfaces, but not sure how to set the new key for use by Comet.

@cason cason added the crypto Cryptography-related label Feb 26, 2024
@tac0turtle
Copy link
Contributor Author

i think the pubkey proto type may need some changing as the current design wouldnt allow register key without redoing the proto types

@melekes
Copy link
Contributor

melekes commented Mar 1, 2024

refs #2399

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto Cryptography-related enhancement New feature or request needs-triage This issue/PR has not yet been triaged by the team.
Projects
Status: Todo
Development

No branches or pull requests

5 participants