modularity: Rolling out new functionality faster, but reliably #42
Labels
major-priority
A major, long-running priority for the team
qa
Quality assurance
tracking
A complex issue broken down into sub-problems
Comments
lasarojc
added
major-priority
3 tasks
adizere
changed the title
adizere
changed the title
cometcrafter
pushed a commit
to graphprotocol/cometbft
that referenced
this issue
May 13, 2024
…et delays (backport cometbft#2952) (cometbft#2975) (cometbft#42) (cometbft#53) Somehow this minint call is appearing in CPU profiles. Its too large of an appearance to be declared as noise, but I really don't get why its there. Must be some weird system effect I don't get. (perhaps due to being the result of a function call for a slice index? idk) This PR just removes the function call, since its not needed, as we already branch on the if statement. Profile showing it:  Contributes a 3% improvement to cometbft#2951 --- #### PR checklist - [x] Tests written/updated - fully compatible with what already exists - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec <hr>This is an automatic backport of pull request cometbft#2952 done by [Mergify](https://mergify.com). --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com> (cherry picked from commit 9ee1d13) Co-authored-by: Adam Tucker <adam@osmosis.team>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
High-level, multi-quarter tracking issue for specific work aiming to make the codebase more malleable, while maintaining high standards in terms of QA. This issue will be expanded over time.
The ecosystem benefits from changes to Tendermint Core/CometBFT relatively slowly. This is partially due to the sheer complexity and entanglement of various parts of the codebase as it has evolved somewhat organically over the years.
Paying off technical debt
Paying off technical debt will enable us to move faster.
RPC
Consensus internal refactoring
Persona: Consensus engine developers
These used to be tracked by #43. Consolidated those issues here:
Related:
Originally tendermint/tendermint#9882
The text was updated successfully, but these errors were encountered: