Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark priority mempool as deprecated in v0.37.x #259

Closed
3 tasks done
Tracked by #39
hvanz opened this issue Feb 2, 2023 · 0 comments
Closed
3 tasks done
Tracked by #39

Mark priority mempool as deprecated in v0.37.x #259

hvanz opened this issue Feb 2, 2023 · 0 comments
Assignees
Labels
Milestone

Comments

@hvanz
Copy link
Member

hvanz commented Feb 2, 2023

We need to mark the priority mempool as deprecated, as decided in #39.

Since these changes only affect the 0.37 release, we should make the PR on v0.37.x, instead of main.

Tasks

  • Add comments with special Deprecated label to relevant public functions.
  • Log a warning message on node startup when "v1" is the mempool version set in the config. For that, update CheckDeprecate() in config/config.go.
  • Update docs

Definition of Done

  • Implementation code complete and all PRs merged
  • Any changes needed to the documentation/spec are merged
@hvanz hvanz added the mempool label Feb 2, 2023
@hvanz hvanz self-assigned this Feb 2, 2023
@hvanz hvanz changed the title Deprecate priority mempool in v0.37 Deprecate priority mempool in v0.37.1 Feb 2, 2023
@hvanz hvanz changed the title Deprecate priority mempool in v0.37.1 Mark priority mempool as deprecated in v0.37.1 Feb 2, 2023
@hvanz hvanz changed the title Mark priority mempool as deprecated in v0.37.1 Mark priority mempool as deprecated in v0.37.x Feb 2, 2023
@hvanz hvanz closed this as completed Feb 23, 2023
@thanethomson thanethomson added this to the 2023-Q1 milestone Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants