Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mempool: Deprecate (v0.37.1) and/or remove (v0.38.0?) the priority mempool #39

Closed
2 tasks done
Tracked by #33
sergio-mena opened this issue Dec 23, 2022 · 0 comments
Closed
2 tasks done
Tracked by #33

mempool: Deprecate (v0.37.1) and/or remove (v0.38.0?) the priority mempool #39

sergio-mena opened this issue Dec 23, 2022 · 0 comments
Assignees
@hvanz
Labels
mempool tracking A complex issue broken down into sub-problems
Milestone
2023-Q1

Comments

@sergio-mena
Copy link
Contributor

sergio-mena commented Dec 23, 2022 •
edited by hvanz
Loading

Was: tendermint/tendermint#9388

In light of ABCI++ landing and, as per the previous discussion in tendermint/tendermint#9388, it was decided to first deprecate the priority mempool for v0.37 and then remove it from v0.38, as its functionality can be obtained by implementing an app-side mempool with ABCI++.

ToDo

For v0.37.1:

For v0.38.0:
@sergio-mena sergio-mena mentioned this issue Dec 23, 2022
Closed
21 tasks
@sergio-mena sergio-mena changed the title mempool: Deprecate the priority mempool mempool: Deprecate (v0.37.1) and/or remove (v0.38.0?) the priority mempool Jan 11, 2023
@sergio-mena sergio-mena mentioned this issue Jan 11, 2023
Closed
38 tasks
@sergio-mena sergio-mena assigned hvanz and unassigned jmalicevic Jan 20, 2023
This was referenced Feb 2, 2023
Closed
Closed
@hvanz hvanz added mempool tracking A complex issue broken down into sub-problems labels Feb 2, 2023
@hvanz hvanz closed this as completed Feb 23, 2023
@thanethomson thanethomson added this to the 2023-Q1 milestone Feb 25, 2023
cometcrafter pushed a commit to graphprotocol/cometbft that referenced this issue May 13, 2024
@mergify @czarcas7ic
perf(consensus/state): Change finalizeCommit to use applyVerifiedBloc… (
720cfe4 
cometbft#39) (cometbft#47)

* perf(consensus/state): Change finalizeCommit to use applyVerifiedBlock (backport cometbft#2928) (cometbft#2945)

Simplest component of cometbft#2854

We already run ValidateBlock in finalizeCommit, so this PR removes one
extra redundant call by using ApplyVerifiedBlock. (The other call is
also redundant, but that likely requires a more complex caching strategy
as noted in cometbft#2854 to remedy)

From my understanding of these benchmarks, at Osmosis 150 validators,
this should be saving ~13ms of execution time per block.

---

#### PR checklist

- [X] Tests written/updated - Theres no test to update, as its
impossible to reach the difference in codepaths!
- [X] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [x] Updated relevant documentation (`docs/` or `spec/`) and code
comments
- [x] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec
<hr>This is an automatic backport of pull request cometbft#2928 done by
[Mergify](https://mergify.com).

---------

Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>

* fix merge conflict

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
(cherry picked from commit 6fe6ee1)

Co-authored-by: Adam Tucker <adam@osmosis.team>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hvanz hvanz

Labels
mempool tracking A complex issue broken down into sub-problems
Projects
No open projects
CometBFT 2023
Status: Done
Milestone
2023-Q1
Development

No branches or pull requests
4 participants
@thanethomson @jmalicevic @sergio-mena @hvanz