Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update description of BlockSync p2p messages in spec #544

Closed
Tracked by #25
sergio-mena opened this issue Mar 17, 2023 · 1 comment
Closed
Tracked by #25

Update description of BlockSync p2p messages in spec #544

sergio-mena opened this issue Mar 17, 2023 · 1 comment
Assignees
@sergio-mena
Labels
abci Application blockchain interface

Comments

@sergio-mena
Copy link
Contributor

Was tendermint/tendermint#9002

Summary

p2p message format for BlockSync messages are out of date for (future) v0.38.x and main branches

Problem Definition

Since the introduction of vote extensions (part of ABCI++) the BlockSync messages (optionally) contain the extended commit corresponding to the the block contained in the p2p blocksync message.

We need to update the p2p spec, in particular, this.
@sergio-mena sergio-mena mentioned this issue Mar 17, 2023
Open
12 tasks
@sergio-mena sergio-mena self-assigned this Mar 17, 2023
@sergio-mena sergio-mena added the abci Application blockchain interface label Mar 17, 2023
@sergio-mena sergio-mena mentioned this issue Mar 17, 2023
Merged
3 tasks
@sergio-mena
Copy link
Contributor Author

Closed by #545

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sergio-mena sergio-mena

Labels
abci Application blockchain interface
Projects
No open projects
CometBFT 2023
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sergio-mena