Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update description of BlockSync p2p messages in spec #9002

Closed
4 tasks
Tracked by #9916
sergio-mena opened this issue Jul 14, 2022 · 0 comments
Closed
4 tasks
Tracked by #9916

Update description of BlockSync p2p messages in spec #9002

sergio-mena opened this issue Jul 14, 2022 · 0 comments
Labels
C:abci Component: Application Blockchain Interface stale for use by stalebot

Comments

@sergio-mena
Copy link
Contributor

sergio-mena commented Jul 14, 2022 •
edited
Loading

Summary

p2p message format for BlockSync messages are out of date for (future) v0.38.x and main branches

Problem Definition

Since the introduction of vote extensions (part of ABCI++) the BlockSync messages (optionally) contain the extended commit corresponding to the the block contained in the p2p blocksync message.

We need to update the p2p spec, in particular, this.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@sergio-mena sergio-mena added this to To do in ABCI++ via automation Jul 14, 2022
@sergio-mena sergio-mena added the C:abci Component: Application Blockchain Interface label Dec 15, 2022
This was referenced Dec 15, 2022
Closed
Closed
@sergio-mena sergio-mena removed this from To do in ABCI++ Dec 21, 2022
@sergio-mena sergio-mena mentioned this issue Dec 23, 2022
Closed
16 tasks
This was referenced Mar 13, 2023
Open
Closed
@github-actions github-actions bot added the stale for use by stalebot label Mar 29, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:abci Component: Application Blockchain Interface stale for use by stalebot
Projects
Tendermint
Status: Done/Merged
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sergio-mena