Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC server: Long Log Messages #654

Closed
1 task
Tracked by #54
gaia opened this issue Apr 5, 2023 · 3 comments · Fixed by #829
Closed
1 task
Tracked by #54

RPC server: Long Log Messages #654

gaia opened this issue Apr 5, 2023 · 3 comments · Fixed by #829
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers logs Anything relating to logging
Milestone

Comments

@gaia
Copy link

gaia commented Apr 5, 2023

Feature Request

Summary

Syslog has trouble handling these long strings (see below). Not sure if they are even needed in logs, but it would surely be great to be able to suppress them, even if syslog gets adjusted to handle them (max message size), just to spare disk IO and reduce log size.

Problem Definition

https://paste2.org/xbEIvUhb

Acceptance criteria

  • truncate the log output in the example above
    • decide if the txs raw bytes are useful in the log in the first place (most likely not useful)
      • if useful: keep a truncated version;
      • if not useful: remove the txs bytes entirely from the log output
@gaia gaia added enhancement New feature or request needs-triage This issue/PR has not yet been triaged by the team. labels Apr 5, 2023
@adizere adizere added good first issue Good for newcomers logs Anything relating to logging and removed needs-triage This issue/PR has not yet been triaged by the team. labels Apr 27, 2023
@adizere
Copy link
Member

adizere commented Apr 27, 2023

Excellent feedback, thanks for logging the issue @gaia !

Will track this under #54, looks like a relatively low-hanging fruit.

@adizere adizere changed the title Long Log Messages RPC server: Long Log Messages Apr 27, 2023
@thanethomson
Copy link
Contributor

What's a good maximum log length here?

@gaia
Copy link
Author

gaia commented May 14, 2023

What's a good maximum log length here?

See #829 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers logs Anything relating to logging
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants