-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming in docker-related files #110
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, thanks @sergio-mena! I've created the corresponding cometbft/cometbft
image repository on Docker Hub and have given the "automation" team (i.e. the bftbot) access to push images: https://hub.docker.com/repository/docker/cometbft/cometbft/general
Thanks a lot @thanethomson ! |
* Performed renaming in docker-related files * Fix e2e launch * one more
Hi, I'm afraid that the changes in |
@cason I agree in the occurrences of Even if it was done by a third party, we are the maintainers of this fork, so it's up to us to decide what to do. I'll open another PR to revert |
* [cherry-picked] Renaming in docker-related files (#110) * Performed renaming in docker-related files * Fix e2e launch * one more * revert rename of tendermint-docker.yml * unrevert renaming tendermint-docker.yml * Rename TENDERMINT_BUILD_OPTIONS to COMETBFT_BUILD_OPTIONS all over * Linter error * Revert `cometbft-proof` to `tendermint-proof` * Replaced TENDERMINT_VERSION --> COMETBFT_VERSION all over the codebase
* [cherry-picked] Renaming in docker-related files (#110) * Performed renaming in docker-related files * Fix e2e launch * Rename TENDERMINT_BUILD_OPTIONS to COMETBFT_BUILD_OPTIONS all over * Revert `cometbft-proof` to `tendermint-proof` * Replaced TENDERMINT_VERSION --> COMETBFT_VERSION all over the codebase
* [backport] Renaming in docker-related files (#123) * [cherry-picked] Renaming in docker-related files (#110) * Performed renaming in docker-related files * Fix e2e launch * Rename TENDERMINT_BUILD_OPTIONS to COMETBFT_BUILD_OPTIONS all over * Revert `cometbft-proof` to `tendermint-proof` * Replaced TENDERMINT_VERSION --> COMETBFT_VERSION all over the codebase * [backport] Rename inside `test/e2e` (#139) (#144) * Renamed all help text for cometbft CLI * Update networks/local/localnode/Dockerfile Co-authored-by: Thane Thomson <connect@thanethomson.com> Co-authored-by: Thane Thomson <connect@thanethomson.com>
Contributes to #103
Criterion for selecting the occurrences of T*** to replace:
As can be seen, I haven't touched the go package names, as this is under another item
PR checklist
CHANGELOG_PENDING.md
updated, or no changelog entry neededdocs/
) and code comments, or nodocumentation updates needed