Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(qa): take parameters from command arguments in python scripts #2665

Merged
merged 9 commits into from Apr 4, 2024

Conversation

hvanz
Copy link
Member

@hvanz hvanz commented Mar 21, 2024

The main changes are to allow setting the scripts' parameters by passing arguments instead of have them hardcoded in variables. The rest is just refactoring to give some structure to the code.


PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments
  • Title follows the Conventional Commits spec

@hvanz hvanz added qa Quality assurance wip Work in progress labels Mar 21, 2024
@hvanz hvanz self-assigned this Mar 21, 2024
@hvanz hvanz removed the wip Work in progress label Mar 21, 2024
@hvanz hvanz changed the title refactor(qa): Improve prometheus_plotter.py refactor(qa): in prometheus_plotter.py, take parameters from command arguments Mar 21, 2024
@hvanz hvanz requested a review from lasarojc March 21, 2024 16:38
@hvanz hvanz marked this pull request as ready for review March 21, 2024 16:38
@hvanz hvanz requested review from a team as code owners March 21, 2024 16:38
@hvanz hvanz marked this pull request as draft March 21, 2024 17:40
@hvanz hvanz changed the title refactor(qa): in prometheus_plotter.py, take parameters from command arguments refactor(qa): take parameters from command arguments in python scripts Mar 21, 2024
@hvanz hvanz marked this pull request as ready for review March 25, 2024 12:40
Co-authored-by: lasaro <lasaro@informal.systems>
@cason
Copy link
Contributor

cason commented Mar 26, 2024

You can make the python scripts executable (chmod 700) then add to their first line:

#!/usr/bin/env python3

This tells the terminal to run the script using python3.

@hvanz hvanz changed the title refactor(qa): take parameters from command arguments in python scripts feat(qa): take parameters from command arguments in python scripts Mar 27, 2024
@adizere adizere added this to the 2024-Q2 milestone Apr 3, 2024
@hvanz hvanz added this pull request to the merge queue Apr 4, 2024
Merged via the queue into main with commit 839d76e Apr 4, 2024
24 checks passed
@hvanz hvanz deleted the hvanz/qa-improve-prometheus-plotter branch April 4, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa Quality assurance
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants