New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(qa): take parameters from command arguments in python scripts #2665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvanz
changed the title
refactor(qa): Improve prometheus_plotter.py
refactor(qa): in prometheus_plotter.py, take parameters from command arguments
Mar 21, 2024
hvanz
changed the title
refactor(qa): in prometheus_plotter.py, take parameters from command arguments
refactor(qa): take parameters from command arguments in python scripts
Mar 21, 2024
lasarojc
reviewed
Mar 25, 2024
Co-authored-by: lasaro <lasaro@informal.systems>
lasarojc
approved these changes
Mar 25, 2024
You can make the python scripts executable (
This tells the terminal to run the script using |
sergio-mena
approved these changes
Mar 26, 2024
hvanz
changed the title
refactor(qa): take parameters from command arguments in python scripts
feat(qa): take parameters from command arguments in python scripts
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main changes are to allow setting the scripts' parameters by passing arguments instead of have them hardcoded in variables. The rest is just refactoring to give some structure to the code.
PR checklist
.changelog
(we use unclog to manage our changelog)docs/
orspec/
) and code comments