Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suppress rejected Tx log to Debug level (backport #306) #314

Merged
merged 3 commits into from
Feb 10, 2023

Conversation

JayT106
Copy link

@JayT106 JayT106 commented Feb 10, 2023

backport #306 to v0.34.x


PR checklist

  • Tests written/updated, or no tests needed
  • CHANGELOG_PENDING.md updated, or no changelog entry needed
  • Updated relevant documentation (docs/) and code comments, or no
    documentation updates needed

@JayT106 JayT106 requested a review from a team as a code owner February 10, 2023 15:13
@codecov-commenter
Copy link

Codecov Report

Base: 48.42% // Head: 48.32% // Decreases project coverage by -0.11% ⚠️

Coverage data is based on head (f055a33) compared to base (3b78343).
Patch coverage: 100.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff             @@
##           v0.34.x     #314      +/-   ##
===========================================
- Coverage    48.42%   48.32%   -0.11%     
===========================================
  Files          280      280              
  Lines        49887    49887              
===========================================
- Hits         24160    24106      -54     
- Misses       23867    23919      +52     
- Partials      1860     1862       +2     
Impacted Files Coverage Δ
mempool/v1/mempool.go 85.58% <100.00%> (ø)
consensus/reactor.go 75.79% <0.00%> (-4.35%) ⬇️
p2p/switch.go 62.81% <0.00%> (-1.35%) ⬇️
mempool/v0/reactor.go 79.76% <0.00%> (-1.20%) ⬇️
blockchain/v0/pool.go 75.82% <0.00%> (-1.02%) ⬇️
blockchain/v0/reactor.go 74.65% <0.00%> (-0.69%) ⬇️
mempool/v1/reactor.go 64.67% <0.00%> (-0.60%) ⬇️
statesync/syncer.go 75.07% <0.00%> (-0.58%) ⬇️
statesync/snapshots.go 93.71% <0.00%> (ø)
proxy/multi_app_conn.go 47.66% <0.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@thanethomson thanethomson merged commit 1fee127 into cometbft:v0.34.x Feb 10, 2023
@thanethomson
Copy link
Contributor

Thanks for this @JayT106!

thanethomson added a commit that referenced this pull request Feb 10, 2023
Signed-off-by: Thane Thomson <connect@thanethomson.com>
thanethomson added a commit that referenced this pull request Feb 10, 2023
* Add changelog entry for #314

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Build changelog with unreleased changes for pre-release

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* version: Set to v0.34.27-alpha.1

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* ci: Update to incorporate/backport changes from #317

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* ci: Simplify release workflow further

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* ci: Add step descriptions for pre-release and release workflows to explain what they do

Signed-off-by: Thane Thomson <connect@thanethomson.com>

---------

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants