Update composer.json

[comur]

Put 2.25.* instead of dev-master because it does not working for me with dev-master:

Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Installation request for cometcult/braintree-bundle dev-master -> satisfiable by cometcult/braintree-bundle[dev-master].
    - cometcult/braintree-bundle dev-master requires braintree/braintree_php dev-master -> no matching package found.

Potential causes:
 - A typo in the package name
 - The package is not available in a stable-enough version according to your minimum-stability setting
   see <https://groups.google.com/d/topic/composer-dev/_g3ASeIFlrc/discussion> for more details.

Read <http://getcomposer.org/doc/articles/troubleshooting.md> for further common problems.

[karolsojko]

@comur dev-master is the current stable release branch so what's the point of fixing on a certain tag ? It would have to be updated once in a while then.

That error in fact occures (if you have a solution for it other then sticking to a tag please supply).
Try to put in you composer.json : "braintree/braintree_php": "dev-master" or running composer require braintree/braintree_php:dev-master before installing cometcult's bundle.

If you know how to fix that in a different manner I would be pleased to know :) Thanks for the PR 👍

[comur]

Hi @karolsojko ,

I already have "braintree/braintree_php": "dev-master" in my composer.json but dev-master of braintree_php is not stable-enough. I think you can just put * and it gets the latest version in configured minimum-stability because it's impossible to install it on a stable project with this configuration

I change my pull request to *. And i also removed bin config because there is no bin dir.

Anyway, thanks for this bundle, it let me save some time.

[karolsojko]

Hi @comur ,

the build on Travis fails because you removed the bin directory config. It's there to indicate that vendor binaries will be symlinked to "bin" folder (it's created after composer installs). When the vendors are installed then phpspec is runned from bin folder in this case. See composer docs for details. So you need to keep it there :)

Additionally you have 3 commits in this PR - it would be cool if you could squash them into 1 commit. Here are some how to

[comur]

Ok i close this one, i deleted and reforked.