8.0.x : Abstract out CometD from Servlet API #1385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
…lasts less than 1ms Signed-off-by: Ludovic Orban <lorban@bitronix.be>
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
lorban
force-pushed
the
8.0.x-servlet-abstraction
branch
from
132ad4e
to
19ee477
Compare
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
* Moved BayeuxServerImpl.findHttpTransport() to AbstractHttpTransport. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Removed blocking HTTP transports, now only non-blocking transports exist. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
…the ee10 version. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
…er-http. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
lorban
commented
Oct 11, 2023
| @@ -15,6 +15,7 @@ | |||
| <module>cometd-java-examples-embedded</module> | |||
| </modules> | |||
|
|
|||
| <!-- There is no support for Jetty 12 in Spring Boot yet | |||
There was a problem hiding this comment.
Spring Boot released the preview version 3.2.0-M3 with support for Jetty 12: https://spring.io/blog/2023/09/21/spring-boot-3-2-0-m3-available-now
It's available in their milestone maven repo.
| public String getCharacterEncoding() { | ||
| String[] split = request.getHeaders().get(HttpHeader.CONTENT_TYPE).split(";"); | ||
| if (split.length == 2) | ||
| return split[1].split("=")[1]; |
There was a problem hiding this comment.
This may throw ArrayIndexOutOfBoundsException, you should check split.split.length.
|
|
||
| @Override | ||
| public List<Locale> getLocales() { | ||
| throw new UnsupportedOperationException("REMOVE API?"); |
There was a problem hiding this comment.
Missed an API decision?
|
|
||
| @Override | ||
| public String getContextInitParameter(String name) { | ||
| throw new UnsupportedOperationException("REMOVE API?"); |
There was a problem hiding this comment.
Missed an API decision?
|
|
||
| @Override | ||
| public List<String> getParameterValues(String name) { | ||
| throw new UnsupportedOperationException("REMOVE API?"); |
There was a problem hiding this comment.
Missed an API decision?
|
|
||
| @Override | ||
| public String getParameter(String name) { | ||
| throw new UnsupportedOperationException("REMOVE API?"); |
There was a problem hiding this comment.
Missed an API decision?
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
… abstraction is done in the outer layer via CometDRequest/CometDResponse. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP.
Create a new SPI that CometD internals relies on to work with the request and the response, then create a Servlet and a Jetty 12 Handler implementation.