cleanup mixed usage of charCode and codePoint #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f165da4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 2566 2661 +95
=========================================
+ Hits 2566 2661 +95 ☔ View full report in Codecov by Sentry. |
cometkim
commented
May 16, 2024
| graphemer 13'101 ns/iter (12'542 ns … 596 µs) 12'875 ns 15'417 ns 109 µs | ||
| grapheme-splitter 27'259 ns/iter (26'583 ns … 508 µs) 26'875 ns 31'500 ns 59'917 ns | ||
| unicode-rs/unicode-segmentation (wasm-pack) 5'590 ns/iter (5'471 ns … 6'420 ns) 5'609 ns 6'361 ns 6'420 ns | ||
| unicode-segmenter 1'820 ns/iter (1'730 ns … 2'428 ns) 1'853 ns 2'228 ns 2'428 ns |
There was a problem hiding this comment.
emoji is the only example here that is slower. I will follow up later to see if there is any specificity to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.