Preserve order of categorized items #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Want to change to |
strfry
force-pushed
the
v2/patch/order_partials
branch
from
1390934
to
43f7e79
Compare
|
Amended the commit, CI is happy now |
strfry
force-pushed
the
v2/patch/order_partials
branch
from
43f7e79
to
d2938a3
Compare
|
I just changed the implementation, now it should preserve the order in all cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch explicitly orders categorized lists by their position stored in the database.
Apparently this behaviour got lost somewhere in the transition to CMS 2.0.