-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sass -> SassC #852
Sass -> SassC #852
Conversation
The Ruby version of Sass is deprecated, see http://sass.logdown.com/posts/7081811
Yeah. I remember reading that sass is not going to be in ruby now. How does this change affect apps on jruby? There was a PR that switched markdown parser to pure ruby at one point. |
sassc-rails currently doesn't work on JRuby (sass/sassc-rails#92), likely due to this JRuby bug: jruby/jruby#4108 JRuby users will have to stay on CMS v2.0.17 until the issue is fixed in JRuby or sassc-rails. |
This change broke my ability to precompile assets and deploy my code. It is also unnecessary - "(That said, the sass-rails folks hope to be compatible with sassc under the hood at some point, so maybe this will be a moot point and we won't have to switch.)" Can we please wait until it is compatible? Waiting a few months won't hurt us. |
This reverts commit 8d8f40f.
The Ruby version of Sass is deprecated, see http://sass.logdown.com/posts/7081811
This reverts commit 8d8f40f.
I'd like to avoid an unnecessary dependency on the sass gem downstream. Why are you still using sass-rails instead of sass-rails? |
It's all about the timing. Currently rails-sass is still supported, and
will continue to be supported until Rails 6.0 comes out, from what I can
tell here rails/rails#32896
Realistically, there are still lots of folks like me who depend on it, and
lots of gems that also depend in it.
…On Sat, Dec 8, 2018 at 3:04 PM Gleb Mazovetskiy ***@***.***> wrote:
I'd like to avoid an unnecessary dependency on the sass gem downstream.
Why are you still using sass-rails instead of sass-rails?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#852 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAGqgCewopKY10S7c65QmMMePcEiVzXPks5u3BtPgaJpZM4YWVyf>
.
|
sassc-rails v2.1.0 has been released just now, it is now JRuby-compatible |
The Ruby version of Sass is deprecated, see http://sass.logdown.com/posts/7081811