Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sass -> SassC #852

Merged
merged 1 commit into from
Nov 24, 2018
Merged

Sass -> SassC #852

merged 1 commit into from
Nov 24, 2018

Conversation

glebm
Copy link
Contributor

@glebm glebm commented Nov 9, 2018

The Ruby version of Sass is deprecated, see http://sass.logdown.com/posts/7081811

The Ruby version of Sass is deprecated, see http://sass.logdown.com/posts/7081811
@GBH
Copy link
Member

GBH commented Nov 9, 2018

Yeah. I remember reading that sass is not going to be in ruby now. How does this change affect apps on jruby? There was a PR that switched markdown parser to pure ruby at one point.

@glebm
Copy link
Contributor Author

glebm commented Nov 10, 2018

sassc-rails currently doesn't work on JRuby (sass/sassc-rails#92), likely due to this JRuby bug: jruby/jruby#4108

JRuby users will have to stay on CMS v2.0.17 until the issue is fixed in JRuby or sassc-rails.

@GBH GBH merged commit 8d8f40f into comfy:master Nov 24, 2018
@glebm glebm deleted the sassc branch November 25, 2018 00:37
@robmathews
Copy link
Contributor

This change broke my ability to precompile assets and deploy my code. It is also unnecessary -

"(That said, the sass-rails folks hope to be compatible with sassc under the hood at some point, so maybe this will be a moot point and we won't have to switch.)"

Can we please wait until it is compatible? Waiting a few months won't hurt us.

robmathews pushed a commit to GoodMeasuresLLC/comfortable-mexican-sofa that referenced this pull request Dec 8, 2018
robmathews pushed a commit to GoodMeasuresLLC/comfortable-mexican-sofa that referenced this pull request Dec 8, 2018
The Ruby version of Sass is deprecated, see http://sass.logdown.com/posts/7081811
robmathews pushed a commit to GoodMeasuresLLC/comfortable-mexican-sofa that referenced this pull request Dec 8, 2018
@glebm
Copy link
Contributor Author

glebm commented Dec 8, 2018

I'd like to avoid an unnecessary dependency on the sass gem downstream. Why are you still using sass-rails instead of sass-rails?

@robmathews
Copy link
Contributor

robmathews commented Dec 9, 2018 via email

@glebm
Copy link
Contributor Author

glebm commented Dec 20, 2018

sassc-rails v2.1.0 has been released just now, it is now JRuby-compatible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants