Convert ES6 JS files to ES5 #901
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why do you need to support IE11 in 2019? |
gabbpuy
approved these changes
Oct 23, 2019
|
@glebm IE 11 is still at around ~3% usage: https://www.stetic.com/market-share/browser/ https://www.w3counter.com/globalstats.php It also breaks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When @glebm converted these files from CoffeeScript to JavaScript, he used ES6. These files break on older browsers like IE 11.
I transpiled them to ES5 using babel.
I think sticking to ES5 is a better solution than adding babel gem dependency complexity.