Get tests running against modern Ruby/Rails versions #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Switches from Travis CI to GitHub Actions * Adds Ruby 3 and 2.7, drops old Ruby versions that are EOL * Test against Rails 6.1 and 6.0, removes 5.2
|
I think GitHub Actions won't run on this repo until there is a workflow in master, but you can see the tests running and passing in my fork here: https://github.com/sailplan/comfortable-mexican-sofa/pull/2 |
Closed
|
Any plan to merge this? At least, #942 needs to be merged in order to run on ruby3.. |
|
@GBH Any chance you could review this or consider adding me as a contributor on this repository? I have a backlog of improvements I'd like to contribute, but I'm not eager to spend the time extracting them from my app unless there's a chance they'll get merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃憢 Thanks for the awesome project. I'm working on a project that makes extensive use of CMS, and I'm hoping to contribute a lot of updates and improvements. But first, I just wanted to get the test running against the latest version of Ruby/Rails, and these were the minimum changes needed to make this happen.
I'd be happy to submit these as separate PRs if you'd prefer.