Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DoRA alpha #3922

Closed
wants to merge 1 commit into from
Closed

Fix DoRA alpha #3922

wants to merge 1 commit into from

Conversation

ntc-ai
Copy link

@ntc-ai ntc-ai commented Jul 1, 2024

This change improves the DoRA implementation by moving the alpha application to after the weight_norm.

This aligns with A1111 allowing DoRA authors to target both platforms.

Example DoRA:
extremely_detailed_v2.zip

Base image (no DoRA)
image

Before patch (attached DoRA same seed)
image
(identity changed)

After patch
image
purrfect

@comfyanonymous
Copy link
Owner

@ntc-ai
Copy link
Author

ntc-ai commented Jul 1, 2024

Thanks for the link, I just opened up an issue here: KohakuBlueleaf/LyCORIS#196

I currently use alpha to adjust strength to the -1 / 1 range which makes my DoRAs more usable / more easily merged.

My goal is to create DoRAs that work across all the different platforms as well as LoRAs do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants