This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
PLAT-101 update build.xml #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -140,4 +140,7 @@ | |||
| <target name="info:code:loc" description="Show stadistics of your lines of code"> | |||
| <exec logoutput="true" command="${c.home}bin/phploc ${app.code}"/> | |||
| </target> | |||
| <target name="info:code:cbf" description="Fix some quality errors of the PHP code."> | |||
| <exec logoutput="true" command="${c.home}bin/phpcbf ${cs.standard} ${app.code}" /> | |||
There was a problem hiding this comment.
Can we get more meaningful names for the property objects please? c. and cs. aren't overly obvious what they are...
There was a problem hiding this comment.
@bimsonz I used c as composer and cs as coding standard, if you have another idea for rename them, happy to change it
There was a problem hiding this comment.
Cool, we need to look at creating a ticket for maybe improving the readability at a later date :)
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://jira.comicrelief.com/browse/PLAT-101