Feature/plat 103 update contrib modules #110
Conversation
Updates to Panels IPE
|
Sorry for auto merge but i need the updates now and dont want to do it twice :) |
…rib_modules Feature/plat 103 update contrib modules
| ->setFormClass('default_content_export', 'Drupal\default_content\ExportEntityForm'); | ||
| $entity_types[$entity_type_id] | ||
| ->setLinkTemplate('export-form', "/$entity_type_id/{{$entity_type_id}}/export"); | ||
| } |
There was a problem hiding this comment.
@bimsonz I git bisect'd in order to find the problem we had with phing login and it shows me that this commit introduced this bug - we'd need to research whether we need to use this version of default_content or better revert to the previous version that does not have this problem.
I assume you just did phing make right?
PS this shows the need of us specifying the commit id in the makefile
There was a problem hiding this comment.
Seems to be introduced in http://cgit.drupalcode.org/default_content/commit/?id=57bfccd and issue https://www.drupal.org/node/2640536
There was a problem hiding this comment.
In my Paragraphs PR the following was brought in
# Information added by drush on 2016-03-12
version: '8.x-1.0-alpha2+22-dev'
via
revision: ae81658
There was a problem hiding this comment.
The newest dev version breaks the node edit interface so rolled back to 22, i think previously we were on 20, maybe we should revert to there
There was a problem hiding this comment.
@bimsonz yes let;s bring back 20 if possible, and fix this in the makefile using the commit id.
To test if all works after rollback, do phing build, then phing login, and then clikc the link. It should not give a fatal error
Fixes https://jira.comicrelief.com/browse/PLAT-103
Changes proposed in this pull request