Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

PLAT-89 Simple XML sitemap (simple_sitemap) #113

Merged
merged 8 commits into from
Mar 24, 2016
Merged

PLAT-89 Simple XML sitemap (simple_sitemap) #113

merged 8 commits into from
Mar 24, 2016

Conversation

vireshpatel
Copy link
Contributor

Ticket

https://jira.comicrelief.com/browse/PLAT-89

Changes proposed in this pull request

  • Adding 'simple_sitemap' to makefile
  • Adding 'simple_sitemap' contrib module
  • Adding 'simple_sitemap' install settings file
  • Adding 'simple_sitemap' to profile
  • Adding 'simple_sitemap' Behat testing feature
  • Adding 'simple_sitemap' Behat testing feature context

Notes

  • URL paths from pages created via Page Manager and Views need to be added manually throught the CMS and the through Custom Links section (in Simple XML Sitemap Settings)
  • Above module settings, include all node content types and the main navigation. The homepage and '/content_wall' has been added as a Custom Link.

Deployment instructions

  • No manual actions required for deployment

Saphyel
Saphyel reviewed Mar 24, 2016
View reviewed changes
profiles/cr/tests/behat/features/simple-xml-sitemap.feature
And I should see "/whats-going-on" as a sitemap url
And I should see "/whats-going-on/british-triathlon-cheers-greg-james-on" as a sitemap url
And I should see "/content-wall" as a sitemap url

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blank spaces in the end of the file!

@Saphyel Saphyel merged commit 1b23b1a into develop Mar 24, 2016
@Saphyel Saphyel deleted the feature/PLAT-89_sitemap branch March 24, 2016 12:31
pvhee
pvhee reviewed Mar 25, 2016
View reviewed changes
profiles/cr/config/install/simple_sitemap.settings.yml
path: /
priority: '1'
-
path: /content-wall
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vireshpatel this needs to be taken out still, as this refers to sample content

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pvhee creating new PR for action:
#118

@pvhee pvhee mentioned this pull request Jan 5, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vireshpatel @pvhee @Saphyel