PLAT-109 Using ds instead of panelizer for articles #116
Conversation
|
@Saphyel fyi |
| @@ -35,3 +36,4 @@ config_devel: | |||
| - views.view.related_news | |||
| - views.view.what_s_going_on | |||
| - pathauto.pattern.article | |||
| - ds.field.related_news | |||
There was a problem hiding this comment.
@gusliedke this is the related news view turned into a DS field, which in turn is then added to the full view mode
…o feature/PLAT-109_article_ds
…o feature/PLAT-109_article_ds
|
It's not passing travis because I've removed block title from news ct. |
|
@gusliedke as mentioned on slack, if a test has been made redundant for whatever reason, we should be making sure that the desired functionality of the original test is still met but reworked to fit the new solution. If the test if no longer relevant at all i guess its safe to remove.. Can you update/ remove the test as appropriate please ? Thoughts @pvhee |
|
Yes, this test is irrelevant. Should I use this branch to remove it? |
|
Yeah don't see why not |
|
@gusliedke so the news page doesn't show anywhere "What's going on" anymore? looks like the region changed (so test needs to fix that) but the title is still there? |
|
I've commented out test whilst we build a new landing page for news. |
gusliedke
added
needs code review
Status: Reviewed
and removed
Status: Needs Work
Status: Reviewed
labels
|
From a review point of view there isnt anything that jumps out that should be there... Cant review the sass but im assuming its all good/ ready for merge. Not tested locally. |
|
@bimsonz @gusliedke all good for me, merging in |
Fixes https://jira.comicrelief.com/browse/PLAT-109
Changes proposed in this pull request
yes, there is a new ticket for that https://jira.comicrelief.com/browse/PLAT-128
whats-going-on/yplan-partners-sport-relief