Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

PLAT-93 Review usage of data analytical modules across different environments #117

Merged
merged 7 commits into from
Mar 31, 2016

Conversation

vireshpatel
Copy link
Contributor

Ticket

Fixes https://jira.comicrelief.com/browse/PLAT-93

Changes proposed in this pull request

  • Remove 'google_tag' module as part of the install profile - Update cr.info.yml
  • Remove 'google_tag' module settings file from profile - Delete google_tag.settings.yml
  • Remove 'crazyegg' module from the install profile - Update cr.info.yml
  • Remove 'crazyegg' module settings file from profile - Delete crazyegg.settings.yml
  • Remove 'optimizely' module from the install profile - Update cr.info.yml
  • Remove 'optimizely' module settings file from profile - Delete optimizely.settings.yml

Reasons for descoping:

  • The 3 modules to be enabled on production always, but disabled on all other environments (and switch on manually when needed).
  • Modules also use account ids from vendors in order to integrate the site and the tracking systems together - these can change at any time.
  • Further more, Optimizely needs to only be active when its required.
  • Optimizely requires manual intervention to setup the configuration. Additional configurations are held in a separate table and are used to connect the drupal pages to the Optimizely system. Therefore doesnt use profile install settings file and doesnt use local environment override config variables.

Deployment instructions

  • No manual actions required for deployment

@pvhee
Copy link
Contributor

pvhee commented Mar 29, 2016

@vireshpatel that looks all good to me, we'll bring in settings back as part of the RND17 build (will create the repo shortly)

@bimsonz OK for you? can you merge pls?

@pvhee
Copy link
Contributor

pvhee commented Mar 29, 2016

PS @vireshpatel you can use MARKDOWN notation rather than 'MARKDOWN' notation, for readibility --- wrapped in ` rather than '

@pvhee
Copy link
Contributor

pvhee commented Mar 30, 2016

@vireshpatel this now has conflicts with the base branch, can you pull again and fix, probably in the settings.yml since also @bimsonz touched this

# Conflicts:
#	profiles/cr/config/install/crazyegg.settings.yml
#	profiles/cr/config/install/google_tag.settings.yml
#	profiles/cr/config/install/optimizely.settings.yml
@vireshpatel
Copy link
Contributor Author

@pvhee conflicts resolved and ready to merge in.

@pvhee pvhee merged commit 4aa4dc7 into develop Mar 31, 2016
@pvhee pvhee deleted the feature/PLAT-93_analytical_modules branch March 31, 2016 16:31
@pvhee pvhee mentioned this pull request Jan 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants