Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

PLAT-108 Remove site map from profile until issue is fixed #123

Merged
merged 4 commits into from
Apr 5, 2016

Conversation

bimsonz
Copy link
Contributor

@bimsonz bimsonz commented Mar 30, 2016

@bimsonz
Copy link
Contributor Author

bimsonz commented Mar 30, 2016

So i've removed simple site map from the profile info file and commented out the tests so the travis build passes... We need to decide whether to merge this in until the bug is fixed...

@bimsonz
Copy link
Contributor Author

bimsonz commented Mar 30, 2016

Found the issue actually resides in simple_sitemap, have posted an issue here: https://www.drupal.org/node/2697097

@bimsonz
Copy link
Contributor Author

bimsonz commented Mar 30, 2016

fyi @vireshpatel

@bimsonz
Copy link
Contributor Author

bimsonz commented Mar 30, 2016

325652094df35bcf246d0a8f7867504122bbf967 is the first bad commit
commit 325652094df35bcf246d0a8f7867504122bbf967
Author: Viresh Patel <viresh.patel@allonesandzeros.co.uk>
Date:   Thu Mar 24 11:38:35 2016 +0000

    PLAT-89 Adding 'simple_sitemap' to profile

:040000 040000 21e7479af2a4f3cd709655c5106fda039f7a61f6 1c58fd95aab4e57386c4831bc6c02da5826295d0 M    profiles

@vireshpatel
Copy link
Contributor

Resolution options:

  • look at other modules
  • enable simple_sitemap after post build
  • investigate simple_sitemap module and contribute to the module/solution
  • wait for updates

Note: message being thrown is a warning and not an actual error.

@bimsonz
Copy link
Contributor Author

bimsonz commented Mar 31, 2016

I'm investigating, will create a patch and update here after

@bimsonz bimsonz assigned bimsonz and unassigned pvhee Apr 1, 2016
@bimsonz
Copy link
Contributor Author

bimsonz commented Apr 4, 2016

Following here: #2696373

Looks like they are trying to push it through between them, would like to patch but need to get the priorities out the way first.

@pvhee
Copy link
Contributor

pvhee commented Apr 5, 2016

@bimsonz see my commit 8a5012c to make this action of test commenting clearer.

Will merge once Travis gives the green light, and you could update this again when the issue moves on d.o.

@pvhee pvhee merged commit 29e9c4e into develop Apr 5, 2016
@pvhee pvhee deleted the feature/PLAT-108_error_in_phing_build branch April 5, 2016 10:05
@pvhee pvhee mentioned this pull request Jan 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants